Skip to content

Fix AMH solution tool ServerMigration_DataReplication #28665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix AMH solution tool ServerMigration_DataReplication #28665

wants to merge 3 commits into from

Conversation

minhsuanlee
Copy link
Contributor

@minhsuanlee minhsuanlee commented Oct 9, 2025 •
edited
Loading

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings October 9, 2025 23:24
@azure-client-tools-bot-prd azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@minhsuanlee minhsuanlee added this to the Az 14.5.0 (10/14/2025) milestone Oct 9, 2025
Copilot
Copilot AI reviewed Oct 9, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes AMH (Azure Migrate Hub) solution tool configuration issues by ensuring the correct tool name "ServerMigration_DataReplication" is consistently passed to Azure Migrate API calls. This addresses replication count missing and UX bifurcation experience issues in the Azure Migrate portal.

  • Updated ChangeLog.md to document the bug fix for Initialize-AzMigrateLocalReplicationInfrastructure
  • Modified the PowerShell function to consistently use the correct tool name "ServerMigration_DataReplication" in all Set-AzMigrateSolution calls
  • Added code formatting improvements with proper brace placement following PowerShell conventions

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/Migrate/Migrate/ChangeLog.md Added changelog entry documenting the bug fix for AMH solution tool name correction
src/Migrate/Migrate.Autorest/custom/Initialize-AzMigrateLocalReplicationInfrastructure.ps1 Updated all Set-AzMigrateSolution calls to use correct tool name and improved code formatting

@isra-fel
Copy link
Member

isra-fel commented Oct 9, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@github-actions GitHub Actions
Copy link

‼️ DO NOT MERGE THIS PR ‼️
This PR was labeled "Do Not Merge" because it contains code change that cannot be merged. Please contact the reviewer for more information.

@minhsuanlee
Copy link
Contributor Author

Validation in dev test pipeline in progress. Will update in a few hours.

@minhsuanlee minhsuanlee removed this from the Az 14.5.0 (10/14/2025) milestone Oct 10, 2025
@isra-fel
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@minhsuanlee
Copy link
Contributor Author

Validation in dev test pipeline in progress. Will update in a few hours.

Dev test run passed: https://dev.azure.com/msazure/One/_build/results?buildId=139892459&view=results

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

+1 more reviewer

@lmawarid lmawarid lmawarid approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@VeryEarly VeryEarly

Labels

Do Not Merge 🚫

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@minhsuanlee @isra-fel @lmawarid @VeryEarly